perf: use errors.New to replace fmt.Errorf with no parameters

main_test.go

@@ -17,6 +17,7 @@
 package gsrpc_test
 
 import (
+	"errors"
 	"fmt"
 	"math/big"
 	"time"
@@ -206,7 +207,7 @@ func Example_makeASimpleTransfer() {
 	// 1 unit of transfer
 	bal, ok := new(big.Int).SetString("100000000000000", 10)
 	if !ok {
-		panic(fmt.Errorf("failed to convert balance"))
+		panic(errors.New("failed to convert balance"))
 	}
 
 	c, err := types.NewCall(meta, "Balances.transfer", bob, types.NewUCompact(bal))

types/address.go

@@ -17,7 +17,7 @@
 package types
 
 import (
-	"fmt"
+	"errors"
 
 	"github.com/centrifuge/go-substrate-rpc-client/v4/scale"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
@@ -91,7 +91,7 @@ func (a *Address) Decode(decoder scale.Decoder) error {
 	}
 
 	if b == 0xfe {
-		return fmt.Errorf("decoding of Address with 0xfe prefix not supported")
+		return errors.New("decoding of Address with 0xfe prefix not supported")
 	}
 
 	if b == 0xfd {

types/bytes.go

@@ -17,7 +17,7 @@
 package types
 
 import (
-	"fmt"
+	"errors"
 
 	"github.com/centrifuge/go-substrate-rpc-client/v4/scale"
 )
@@ -42,7 +42,7 @@ func (b BytesBare) Encode(encoder scale.Encoder) error {
 
 // Decode does nothing and always returns an error. BytesBare is only used for encoding, not for decoding
 func (b *BytesBare) Decode(decoder scale.Decoder) error {
-	return fmt.Errorf("decoding of BytesBare is not supported")
+	return errors.New("decoding of BytesBare is not supported")
 }
 
 // Bytes8 represents an 8 byte array

types/digest_item.go

@@ -18,7 +18,6 @@ package types
 
 import (
 	"fmt"
-
 	"github.com/centrifuge/go-substrate-rpc-client/v4/scale"
 )
 
@@ -151,7 +150,7 @@ func (c ChangesTrieSignal) Encode(encoder scale.Encoder) error {
 			return err
 		}
 	default:
-		return fmt.Errorf("no such variant for ChangesTrieSignal")
+		return errors.New("no such variant for ChangesTrieSignal")
 	}
 
 	return nil
@@ -171,7 +170,7 @@ func (c *ChangesTrieSignal) Decode(decoder scale.Decoder) error {
 			return err
 		}
 	default:
-		return fmt.Errorf("no such variant for ChangesTrieSignal")
+		return errors.New("no such variant for ChangesTrieSignal")
 	}
 
 	return nil

types/extrinsic_payload.go

@@ -17,7 +17,7 @@
 package types
 
 import (
-	"fmt"
+	"errors"
 
 	"github.com/centrifuge/go-substrate-rpc-client/v4/scale"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/signature"
@@ -93,7 +93,7 @@ func (e ExtrinsicPayloadV3) Encode(encoder scale.Encoder) error {
 
 // Decode does nothing and always returns an error. ExtrinsicPayloadV3 is only used for encoding, not for decoding
 func (e *ExtrinsicPayloadV3) Decode(decoder scale.Decoder) error {
-	return fmt.Errorf("decoding of ExtrinsicPayloadV3 is not supported")
+	return errors.New("decoding of ExtrinsicPayloadV3 is not supported")
 }
 
 type ExtrinsicPayloadV4 struct {

types/metadataV10.go

@@ -233,7 +233,7 @@ func (s StorageFunctionMetadataV10) IsMap() bool {
 
 func (s StorageFunctionMetadataV10) Hashers() ([]hash.Hash, error) {
 	if !s.IsMap() {
-		return nil, fmt.Errorf("Hashers() is only to be called on Maps")
+		return nil, errors.New("Hashers() is only to be called on Maps")
 	}
 
 	var hashers = collectHashersV10(s.Type)

types/metadataV7.go

@@ -17,6 +17,7 @@
 package types
 
 import (
+	"errors"
 	"fmt"
 	"hash"
 	"strings"
@@ -220,7 +221,7 @@ func (s StorageFunctionMetadataV5) IsMap() bool {
 
 func (s StorageFunctionMetadataV5) Hashers() ([]hash.Hash, error) {
 	if !s.IsMap() {
-		return nil, fmt.Errorf("Hashers() is only to be called on Maps")
+		return nil, errors.New("Hashers() is only to be called on Maps")
 	}
 
 	var hashers = collectHashersV5(s.Type)

types/moment.go

@@ -17,7 +17,7 @@
 package types
 
 import (
-	"fmt"
+	"errors"
 	"math"
 	"time"
 
@@ -48,7 +48,7 @@ func (m *Moment) Decode(decoder scale.Decoder) error {
 
 	// Error in case of overflow
 	if u > math.MaxInt64 {
-		return fmt.Errorf("cannot decode a uint64 into a Moment if it overflows int64")
+		return errors.New("cannot decode a uint64 into a Moment if it overflows int64")
 	}
 
 	secs := u / MillisInSecond

types/storage_change_set.go

@@ -18,6 +18,7 @@ package types
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
@@ -42,7 +43,7 @@ func (r *KeyValueOption) UnmarshalJSON(b []byte) error {
 	}
 	switch len(tmp) {
 	case 0:
-		return fmt.Errorf("expected at least one entry for KeyValueOption")
+		return errors.New("expected at least one entry for KeyValueOption")
 	case 2:
 		r.HasStorageData = true
 		data, err := codec.HexDecodeString(tmp[1])

types/storage_key.go

@@ -17,6 +17,7 @@
 package types
 
 import (
+	"errors"
 	"fmt"
 	"io"
 
@@ -56,7 +57,7 @@ func CreateStorageKey(meta *Metadata, prefix, method string, args ...[]byte) (St
 
 		for i := nonNilCount; i < len(args); i++ {
 			if len(args[i]) != 0 {
-				return nil, fmt.Errorf("non-nil arguments cannot be preceded by nil arguments")
+				return nil, errors.New("non-nil arguments cannot be preceded by nil arguments")
 			}
 		}