Server, lib exports, and readme adjustments #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulLeCam
reviewed
Apr 17, 2024
gvelez17
reviewed
Apr 17, 2024
gvelez17
reviewed
Apr 17, 2024
| }) | ||
|
|
||
|
|
||
| return { contextWriter, totalWriter, contextReader, totalReader } |
There was a problem hiding this comment.
this is ok if you also expose the ceramic client but if not, how do i use the allocation models also?
There was a problem hiding this comment.
I'm a little confused about where the CeramicClient instances are instantiated - is there just one or more than one? i guess since its just http requests it doesn't matter too much we just need the url?
PaulLeCam
reviewed
Apr 18, 2024
PaulLeCam
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments to server logic and library exports given default node endpoint update: