Skip to content

Commit

Permalink
chore(deps-dev): update development dependencies to v8 (major) (#986)
Browse files Browse the repository at this point in the history
* chore(deps-dev): update development dependencies to v8

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix lint errors

Signed-off-by: Andrew Haines <[email protected]>

* Enable project service

Signed-off-by: Andrew Haines <[email protected]>

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Andrew Haines <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andrew Haines <[email protected]>
  • Loading branch information
renovate[bot] and haines authored Aug 5, 2024
1 parent fbd4542 commit 324cd23
Show file tree
Hide file tree
Showing 8 changed files with 120 additions and 54 deletions.
6 changes: 5 additions & 1 deletion .eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ root: true

parser: "@typescript-eslint/parser"
parserOptions:
project: true
projectService: true

plugins:
- eslint-plugin-tsdoc
Expand All @@ -22,6 +22,10 @@ rules:
"@typescript-eslint/explicit-function-return-type": warn
"@typescript-eslint/explicit-member-accessibility": warn
"@typescript-eslint/no-confusing-void-expression": warn
"@typescript-eslint/no-require-imports":
- warn
- allow:
- /package\.json$
"@typescript-eslint/no-unnecessary-condition":
- warn
- allowConstantLoopConditions: true
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
"@tsconfig/node18": "18.2.4",
"@tsconfig/strictest": "2.0.5",
"@types/node": "18.19.43",
"@typescript-eslint/eslint-plugin": "7.18.0",
"@typescript-eslint/parser": "7.18.0",
"@typescript-eslint/eslint-plugin": "8.0.0",
"@typescript-eslint/parser": "8.0.0",
"concurrently": "8.2.2",
"depcheck": "1.4.7",
"eslint": "8.57.0",
Expand Down
4 changes: 1 addition & 3 deletions packages/core/src/convert/fromProtobuf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -848,9 +848,7 @@ function planResourcesMetadataFromProtobuf({
const unexpected = Symbol("unexpected");
type Unexpected = typeof unexpected;

function isUnexpected<T>(
value: T | Unexpected | undefined,
): value is Unexpected | undefined {
function isUnexpected(value: unknown): value is Unexpected | undefined {
return value === unexpected || value === undefined;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class NotOK extends Error {
try {
const error: unknown = JSON.parse(text);
return new NotOK(code(error), details(error));
} catch (_) {
} catch {
return new NotOK(Status.UNKNOWN, text);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/embedded/src/bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export class Bundle {

try {
return CheckResourcesResponse.fromJSON(JSON.parse(responseText));
} catch (_) {
} catch {
throw NotOK.fromJSON(responseText);
}
}
Expand Down
8 changes: 4 additions & 4 deletions packages/embedded/src/transport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ export class Transport implements _Transport {
notImplemented(method);
}

public serverStream<
Service extends _Service,
Method extends _Method<Service, "serverStream">,
>(_: Service, method: Method): never {
public serverStream<Service extends _Service>(
_: Service,
method: _Method<Service, "serverStream">,
): never {
notImplemented(method);
}
}
Expand Down
146 changes: 105 additions & 41 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion private/scripts/src/utils/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const isoDateSchema = z.string().refine(
(value) => {
try {
return value === formatISO(parseISO(value), { representation: "date" });
} catch (error) {
} catch {
return false;
}
},
Expand Down

0 comments on commit 324cd23

Please sign in to comment.