Skip to content

Commit

Permalink
chore(deps-dev): update development dependencies (#1018)
Browse files Browse the repository at this point in the history
* chore(deps-dev): update development dependencies

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Migrate away from deprecated semantic attributes

open-telemetry/opentelemetry-js#4690

Signed-off-by: Andrew Haines <[email protected]>

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Andrew Haines <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andrew Haines <[email protected]>
  • Loading branch information
renovate[bot] and haines authored Sep 30, 2024
1 parent 613308b commit 977ae1b
Show file tree
Hide file tree
Showing 8 changed files with 203 additions and 214 deletions.
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "cerbos-sdk-javascript",
"private": true,
"packageManager": "pnpm@9.10.0",
"packageManager": "pnpm@9.11.0",
"engines": {
"node": "22.9.0",
"pnpm": "9.10.0"
"pnpm": "9.11.0"
},
"scripts": {
"all:parallel": "concurrently --group --prefix=none",
Expand Down Expand Up @@ -55,9 +55,9 @@
"@microsoft/api-extractor": "7.47.9",
"@tsconfig/node18": "18.2.4",
"@tsconfig/strictest": "2.0.5",
"@types/node": "18.19.50",
"@typescript-eslint/eslint-plugin": "8.6.0",
"@typescript-eslint/parser": "8.6.0",
"@types/node": "18.19.53",
"@typescript-eslint/eslint-plugin": "8.7.0",
"@typescript-eslint/parser": "8.7.0",
"concurrently": "9.0.1",
"depcheck": "1.4.7",
"eslint": "8.57.1",
Expand Down
4 changes: 3 additions & 1 deletion packages/opentelemetry/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

## [Unreleased]

No notable changes.
### Changed

- Migrate away from [deprecated semantic attributes](https://github.com/open-telemetry/opentelemetry-js/pull/4690) ([#1018](https://github.com/cerbos/cerbos-sdk-javascript/pull/1018))

## [0.5.3] - 2024-09-23

Expand Down
7 changes: 7 additions & 0 deletions packages/opentelemetry/changelog.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
unreleased:
type: patch

changed:
- summary: Migrate away from [deprecated semantic attributes](https://github.com/open-telemetry/opentelemetry-js/pull/4690)
pull: 1018

releases:
- version: 0.5.3
date: 2024-09-23
Expand Down
20 changes: 10 additions & 10 deletions packages/opentelemetry/src/transport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import {
trace,
} from "@opentelemetry/api";
import {
SEMATTRS_RPC_GRPC_STATUS_CODE,
SEMATTRS_RPC_METHOD,
SEMATTRS_RPC_SERVICE,
SEMATTRS_RPC_SYSTEM,
} from "@opentelemetry/semantic-conventions";
ATTR_RPC_GRPC_STATUS_CODE,
ATTR_RPC_METHOD,
ATTR_RPC_SERVICE,
ATTR_RPC_SYSTEM,
} from "@opentelemetry/semantic-conventions/incubating";

import type {
_AbortHandler,
Expand Down Expand Up @@ -162,9 +162,9 @@ export class Transport implements _Transport {
const status: SpanStatus = { code: SpanStatusCode.UNSET };

const attributes: Attributes = {
[SEMATTRS_RPC_SYSTEM]: "grpc",
[SEMATTRS_RPC_SERVICE]: serviceName,
[SEMATTRS_RPC_METHOD]: methodName,
[ATTR_RPC_SYSTEM]: "grpc",
[ATTR_RPC_SERVICE]: serviceName,
[ATTR_RPC_METHOD]: methodName,
};

const span = this.tracer.startSpan(`${serviceName}/${methodName}`, {
Expand All @@ -189,7 +189,7 @@ export class Transport implements _Transport {

const call = {
succeeded: (): void => {
attributes[SEMATTRS_RPC_GRPC_STATUS_CODE] = Status.OK;
attributes[ATTR_RPC_GRPC_STATUS_CODE] = Status.OK;
finish();
},
failed: (error: unknown): void => {
Expand All @@ -200,7 +200,7 @@ export class Transport implements _Transport {
attributes["cerbos.error"] = error.message;

if (error instanceof NotOK) {
attributes[SEMATTRS_RPC_GRPC_STATUS_CODE] = error.code;
attributes[ATTR_RPC_GRPC_STATUS_CODE] = error.code;
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"use-deep-compare-effect": "^1.8.1"
},
"devDependencies": {
"@types/react": "18.3.8",
"@types/react": "18.3.9",
"eslint-plugin-react-hooks": "4.6.2"
},
"publishConfig": {
Expand Down
Loading

0 comments on commit 977ae1b

Please sign in to comment.