Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

R4 Appointment updates #988

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

amcginn
Copy link
Member

@amcginn amcginn commented Sep 22, 2023

Description

Update the R4 Appointment resource for consistency and readability.

PR Checklist

  • Screenshot(s) of changes attached before changes merged.
  • Screenshot(s) of changes attached after changes merged and published.

Changes

Overview
before:
Screenshot 2023-09-22 at 13-00-34 Appointment R4 API

after:
Screenshot 2023-09-22 at 13-01-10 Appointment R4 API

Fields
before:
Screenshot 2023-09-22 at 13-17-46 Appointment R4 API

after:
Screenshot 2023-09-22 at 13-18-20 Appointment R4 API
disclaimer and errors sentence were moved here and removed from each example

Search parameters
before:
Screenshot 2023-09-22 at 13-23-50 Appointment R4 API

after (reordered, put field names as code, updated examples):
Screenshot 2023-09-22 at 13-24-47 Appointment R4 API

Search notes
before:
Screenshot 2023-09-22 at 13-37-37 Appointment R4 API

after:
Screenshot 2023-09-22 at 13-37-50 Appointment R4 API

Patch status
before:
Screenshot 2023-09-22 at 14-10-48 Appointment R4 API

after:
Screenshot 2023-09-22 at 14-17-22 Appointment R4 API

Patch video visit fields (common change on all fields)
before:
Screenshot 2023-09-22 at 14-23-54 Appointment R4 API

after:
Screenshot 2023-09-22 at 14-24-21 Appointment R4 API

Copy link
Contributor

@kckeim kckeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm annoyed on your behalf, @amcginn, that you had to correct so much poor grammar.
You caught all the ones that rubbed me the wrong way, and then some - it makes a lot more sense now.
Looks like you caught all the bad links too.

I'm marking as approved, but I do have a couple points of commentary to make sure we're being consistent with what our pages are supposed to look like (at least going forward).


I don't know if we want to keep the disclaimer following all responses as a self-protective step, or switch to what you did with the one disclaimer section towards the top. It certainly cuts down on the extra page space, but all of our other pages seems to have the disclaimers on there repeatedly. Do you want to make a call either way, or decide as a group, so we can be consistent?


Do we want to call out the specific read / write scopes that are referenced in the PATCH section's Implementation notes on line 179 of your corrected appointment.md file?
This'd be something like Appointment.read and Appointment.create unless we want to keep the scopes non-specific - what's your opinion here?

image

@amcginn
Copy link
Member Author

amcginn commented Oct 3, 2023

@kckeim

I don't know if we want to keep the disclaimer following all responses as a self-protective step, or switch to what you did with the one disclaimer section towards the top. It certainly cuts down on the extra page space, but all of our other pages seems to have the disclaimers on there repeatedly. Do you want to make a call either way, or decide as a group, so we can be consistent?

I thought we talked about this in scrum on the 22nd before I was out. Though, now I'm not sure you were there. It may have just been a missed communication on my part.

Do we want to call out the specific read / write scopes that are referenced in the PATCH section's Implementation notes on line 179 of your corrected appointment.md file? This'd be something like Appointment.read and Appointment.create unless we want to keep the scopes non-specific - what's your opinion here?

I like that. We should be definitely be specific where it's easy to do so.

@amcginn
Copy link
Member Author

amcginn commented Oct 3, 2023

Updated to specify scopes explicitly.

Screenshot 2023-10-03 at 14-33-23 Appointment R4 API

@amcginn amcginn merged commit 33ed2af into cerner:main Oct 3, 2023
1 check passed
@amcginn amcginn deleted the appointment-r4-updates branch October 3, 2023 20:05
Someshnsn added a commit that referenced this pull request Nov 10, 2023
 
* R4 Appointment updates (#988)
* Diagnostic report r4 docs migrate (#991)
* Updated DiagnosticReport DSTU2 Resource (#992)
* Update DSTU 2 Appointment documentation (#993)
* R4_UK_BRAM_Update_Slot_include (#994)
* Reorder actions to Search, Read, Create, Patch (#995)
* Review and Corrections for Condition (#996)
* Update action-comment in cancellation workflow and custom encounter search (#997)
* Updated DocumentReference R4 Resource (#999)
* Review and updates for Location (#1001)
* Diagnostic Report Create for Cardiology and Anatomic pathology (#1002)
* Review and Updates for Encounter (#1007)
* Review and Updates for NutritionOrder (#1008)
@Surya-Rnsit
Copy link
Contributor

After Code Deployment:
Screenshot 2023-11-10 at 3 44 51 PM
Screenshot 2023-11-10 at 3 44 30 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants