Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Commit

Permalink
[terra-hyperlink] Fix focus indicator
Browse files Browse the repository at this point in the history
  • Loading branch information
cm9361 committed Mar 28, 2024
1 parent f819166 commit d837470
Show file tree
Hide file tree
Showing 27 changed files with 13 additions and 99 deletions.
12 changes: 5 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

3 changes: 3 additions & 0 deletions packages/terra-hyperlink/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Fixed
* Fixed focus indicator for default and lowlight themes.

## 2.68.0 - (March 27, 2024)

* Changed
Expand Down
4 changes: 3 additions & 1 deletion packages/terra-hyperlink/src/Hyperlink.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,10 @@
&[data-focus-styles-enabled='true']:focus {
background-color: var(--terra-hyperlink-focus-background-color, transparent);
border-radius: var(--terra-hyperlink-focus-border-radius, 0.2142rem);
box-shadow: var(--terra-hyperlink-focus-box-shadow, 0 0 0 1px #4cb2e9, 0 0 0 3px rgba(76, 178, 233, 0.25));
box-shadow: var(--terra-hyperlink-focus-box-shadow, none);
color: var(--terra-hyperlink-focus-color, #001f67);
outline: var(--terra-hyperlink-focus-outline, 2px dashed #000);
outline-offset: var(--terra-hyperlink-focus-outline-offset, 1px);
text-decoration: var(--terra-hyperlink-focus-text-decoration, underline);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
--terra-hyperlink-hover-text-decoration: underline;
--terra-hyperlink-focus-background-color: transparent;
--terra-hyperlink-focus-border-radius: 0.2142rem;
--terra-hyperlink-focus-box-shadow: 0 0 1px 3px #004c76, 0 0 7px 4px #004c76;
--terra-hyperlink-focus-outline: 2px dashed #fff;
--terra-hyperlink-focus-color: #007ee0;
--terra-hyperlink-focus-text-decoration: underline;
--terra-hyperlink-active-color: #007ee0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
--terra-hyperlink-focus-background-color: transparent;
--terra-hyperlink-focus-border-radius: 3px;
--terra-hyperlink-focus-box-shadow: 0 0 0 1px #4cb2e9, 0 0 0 3px rgba(76, 178, 233, 0.25);
--terra-hyperlink-focus-outline: none;
--terra-hyperlink-focus-color: #004c76;
--terra-hyperlink-focus-text-decoration: underline;
--terra-hyperlink-active-color: #0065a3;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
12 changes: 0 additions & 12 deletions packages/terra-hyperlink/tests/wdio/hyperlink-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,6 @@ Terra.describeViewports('Hyperlink', ['tiny'], () => {
Terra.validates.element('scaled');
});

it('should display hyperlink states', () => {
browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/states-hyperlink');

Terra.validates.element('states');
});

it('should display Hyperlink with hidden underline', () => {
browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/underline-hidden-hyperlink');

Expand All @@ -80,12 +74,6 @@ Terra.describeViewports('Hyperlink', ['tiny'], () => {
Terra.validates.element('focused hyperlink button');
});

it('should render Hyperlink Button states when onClick is provided', () => {
browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/states-hyperlink-button');

Terra.validates.element('hyperlink-button');
});

it('should render Hyperlinks with ellipses when the context should overflow', () => {
browser.url('/raw/tests/cerner-terra-core-docs/hyperlink/truncated-hyperlink');
Terra.validates.element('truncated');
Expand Down

0 comments on commit d837470

Please sign in to comment.