Review comments

cerner · Jul 13, 2023 · e2ec97e · e2ec97e
1 parent 36751ca
commit e2ec97e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/packages/terra-content-container/CHANGELOG.md b/packages/terra-content-container/CHANGELOG.md
@@ -3,7 +3,7 @@
 ## Unreleased
 
 * Changed
-  * Addressed the focus style on click issue when `setFocusOnContainer` is not set
+  * Updated focus style when `setFocusOnContainer` is not set.
 
 ## 3.39.0 - (June 28, 2023)
 

diff --git a/packages/terra-content-container/src/ContentContainer.jsx b/packages/terra-content-container/src/ContentContainer.jsx
@@ -62,7 +62,7 @@ const ContentContainer = ({
   ...customProps
 }) => {
   const theme = React.useContext(ThemeContext);
-  const lightbackground = 'light';
+  const lightBackground = 'light';
 
   const contentLayoutClassNames = cx([
     `content-container-${fill ? 'fill' : 'static'}`,
@@ -72,7 +72,7 @@ const ContentContainer = ({
   // setting tab index to 0 if setFocusOnContainer is set
   const scrollAttrs = (setFocusOnContainer) ? { tabIndex: 0 } : '';
   // border will only be visible when setFocusOnContainer is set for content-container
-  const background = setFocusOnContainer && (backgroundColor || lightbackground);
+  const background = setFocusOnContainer && (backgroundColor || lightBackground);
   const scrollClassNames = cx(
     'normalizer',
     theme.className,

diff --git a/packages/terra-core-docs/CHANGELOG.md b/packages/terra-core-docs/CHANGELOG.md
@@ -2,11 +2,17 @@
 
 ## Unreleased
 
+* Added
+  * Added a test case for click event when setFocusOnContainer is disabled
+
 * Changed
   * Minor formatting update in `terra-alert` & `terra-form-fieldset`.
 
 ## 1.30.0 - (July 11, 2023)
 
+* Added
+  * Added test example for controlled form native select component.
+
 * Added
   * Added test example for controlled form native select component.
   * Added more realistic examples for terra-toggle-button.