This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-form-select] Native Select allow initial values #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
reviewed
Jun 26, 2023
sdadn
suggested changes
Jun 26, 2023
sdadn
changed the title
supreethmr
reviewed
Jul 1, 2023
| const refIsControlled = isValuePresent(value); | ||
|
|
||
| useEffect(() => { | ||
| // added this to allow initial null values |
There was a problem hiding this comment.
I think this condition was not added to allow initial null values !!
supreethmr
approved these changes
Jul 3, 2023
ShettyAkarsh
approved these changes
Jul 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Changes made to allow initial null value.
Why it was changed:
NativeSelect does not allow updating the value prop in subsequent renders
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9184
Thank you for contributing to Terra.
@cerner/terra