This repository has been archived by the owner on May 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[terra-show-hide] prop to focus on the element added #3838
[terra-show-hide] prop to focus on the element added #3838
Changes from 10 commits
3696633
94d6602
8a20716
b18c84a
89be1c4
5f0bf23
b1cb04c
c3ece59
9a5deff
072099c
b230366
52bcd8f
848c29f
ccf7a43
b28173d
a8e457b
c7a4f09
f21df4a
d506978
41f2664
af989d2
bf7a1c8
65bd67e
ec8e2fe
aed44ee
afa2305
eb321d7
8329d69
7331103
0cca372
db8474e
a73b621
76da4f0
aebb65b
1058492
b87f7ad
6d1d090
25e6d2b
74d9818
7e33876
efbb870
535dadd
170f7cb
22a779d
831987f
4d398fe
d6b8635
3db7955
39e028f
3cc0b6f
ae25222
b37422c
1be999d
6ecb098
94850b3
c68c5b5
abc4eda
936edf6
6c7525b
6e47ea6
7b4be27
8a4a7f9
74096b1
d49e829
ec0f3e7
0156351
c605fd9
1835ec8
b29f4c6
cc85388
e77057f
4357670
ca05167
7181971
85736f7
0db375b
e8c4f6d
e894289
d341177
d662383
00d860f
9ca3ff7
7d0d3fb
09d4e45
eb4d10d
0d1dbe5
11668ab
0986b97
ef2f17d
35bfc7e
fff0ad2
877b70a
eecfd9a
a742c20
f7d993c
a616917
fce63fe
1813b07
67dcc73
c8f17c0
8493e05
aa41c4b
a47b7a6
2e998eb
822fe03
41cac25
6ad93a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this section would be better placed after the "Examples" section that explains the basic usage.
Edit: Nvm I see we have it this way in the "Alert" component page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I am also not sure where to place that block. We might want to re-visit that question after the rest of documentation is approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intended change to use same ref for two different html elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
<span>
node created on line 27 needs to be accessed in the<ShowHide>
component in order to receive focus, so<ShowHide>
is taking a focusRef prop, which will the reference to the<span>
.I understand that it's confusing as I don't use ref forwarding. The reason for that is following:
span
node and both created at the same component;focusRef
;But I am open for suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these style blocks can be combined. It is the same style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, at some point I was trying different styles and left it separated. Fixed here: 1058492