Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-form-input] Adding doc warning about chromium VO bug #3840

Merged
merged 11 commits into from
Jul 18, 2023
Merged

[terra-form-input] Adding doc warning about chromium VO bug #3840

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c122afb
adding in new section to form-inputs about doc warning about chromium…
BenBoersma Jul 10, 2023
17557c3
Address PR comments
BenBoersma Jul 10, 2023
f64a53c
Merge branch 'main' into add-warning-to-form-input
BenBoersma Jul 10, 2023
fbc8fe6
Addressing PR comments
BenBoersma Jul 11, 2023
33f18f4
Merge branch 'add-warning-to-form-input' of github.com:cerner/terra-c…
BenBoersma Jul 11, 2023
69cbe68
Merge branch 'main' into add-warning-to-form-input
BenBoersma Jul 11, 2023
3d675a5
fixing changelog resolve errors
BenBoersma Jul 12, 2023
df42ffa
Merge branch 'main' into add-warning-to-form-input
BenBoersma Jul 14, 2023
9acb84b
We should be using actual terra-form-inout not basic html, did not th…
BenBoersma Jul 14, 2023
095129e
Update packages/terra-core-docs/src/terra-dev-site/doc/form-input/Abo…
BenBoersma Jul 17, 2023
38f0c8b
Update packages/terra-core-docs/CHANGELOG.md
BenBoersma Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/terra-core-docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# Changelog

## Unreleased
* Added
* Added test example for controlled form native select component.

* Added
* Added documentation updates for `Single Select` in `terra-form-select`.
sycombs marked this conversation as resolved.
Show resolved Hide resolved
* Added documentation updates for `terra-form-input`.
* Added test example for controlled form native select component.
* Added more realistic examples for terra-toggle-button.

## 1.29.0 - (June 28, 2023)
Expand Down
7 changes: 7 additions & 0 deletions packages/terra-core-docs/src/terra-dev-site/doc/form-input/About.1.doc.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Badge } from 'terra-form-input/package.json?dev-site-package';
import { Notice } from '@cerner/terra-docs';

import BlankExample from './common/BlankExample?dev-site-example';
import NumberInputExample from './common/NumberInputExample?dev-site-example';
Expand Down Expand Up @@ -26,6 +27,12 @@ Generic input which represents an HTML input element directly.

**Note:** To follow [UX Best Practices](https://www.w3.org/WAI/GL/low-vision-a11y-tf/wiki/Placeholder_Research), this component does not allow `placeholder`.

<Notice variant="caution" ariaLevel="3">

**Accessibility Bug:** Due to a bug in Chromium-based browsers (Chrome, Microsoft Edge, etc.), VoiceOver would read `<input type="number" />` incorrectly when incrementing or decrementing the value with keyboard shortcuts. Terra Form Input utilizes `<input type="number" />` when the `type` prop is set to "number" and will also have this screenreader issue. An alternative is to use something like `<input type="text" inputmode="numeric" pattern="\d*" />`. However, this will have no built in validity checks or keyboard commands. Consumers are responsible for adding this functionality.
BenBoersma marked this conversation as resolved.
Show resolved Hide resolved

</Notice>

## Getting Started

- Install with [npmjs](https://www.npmjs.com):
Expand Down
Loading