Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[Terra-Tag] SR announces instructions twice with VPC ON Mode #3978

Merged
merged 4 commits into from
Nov 24, 2023
Merged

[Terra-Tag] SR announces instructions twice with VPC ON Mode #3978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62494fe
Terra-Tag SR issue fixed
Nov 17, 2023
9e1643d
code update
Nov 20, 2023
9b18666
removed Aria-live
Nov 23, 2023
a97b8e7
snapshot updated
Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/terra-tag/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Fixed
* Fixed Terra-Tag SR announces instructions twice with VPC ON Mode

## 2.64.1 - (November 16, 2023)

* Fixed
Expand Down
2 changes: 0 additions & 2 deletions packages/terra-tag/src/_RollupTag.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,7 @@ const RollUpTag = (props) => {
onBlur={handleOnBlur}
refCallback={(ref) => { rollUpTagRef.current = ref; }}
isCompact
aria-live={(isCollapsed) ? 'polite' : 'off'}
aria-label={rollUpHint}
aria-describedby={rollUpHint}
aria-atomic="true"
data-terra-rollup-tag-show-focus-styles
data-terra-rollup-tag
Expand Down
12 changes: 0 additions & 12 deletions packages/terra-tag/tests/jest/__snapshots__/RollUpTag.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ exports[`Rollup Tag should render rollup tag with the label "4 more" 1`] = `
>
<Button
aria-atomic="true"
aria-describedby="Terra.tags.hint.rollupTag"
aria-label="Terra.tags.hint.rollupTag"
aria-live="polite"
className="rollup-tag"
data-terra-rollup-tag={true}
data-terra-rollup-tag-show-focus-styles={true}
Expand All @@ -88,10 +86,8 @@ exports[`Rollup Tag should render rollup tag with the label "4 more" 1`] = `
>
<button
aria-atomic="true"
aria-describedby="Terra.tags.hint.rollupTag"
aria-disabled={false}
aria-label="Terra.tags.hint.rollupTag"
aria-live="polite"
className="button neutral compact rollup-tag"
data-terra-rollup-tag={true}
data-terra-rollup-tag-show-focus-styles={true}
Expand Down Expand Up @@ -185,9 +181,7 @@ exports[`Rollup Tag should render rollup tag with the label "show less" when isC
>
<Button
aria-atomic="true"
aria-describedby="Terra.tags.hint.showLess"
aria-label="Terra.tags.hint.showLess"
aria-live="off"
className="rollup-tag"
data-terra-rollup-tag={true}
data-terra-rollup-tag-show-focus-styles={true}
Expand All @@ -208,10 +202,8 @@ exports[`Rollup Tag should render rollup tag with the label "show less" when isC
>
<button
aria-atomic="true"
aria-describedby="Terra.tags.hint.showLess"
aria-disabled={false}
aria-label="Terra.tags.hint.showLess"
aria-live="off"
className="button neutral compact rollup-tag"
data-terra-rollup-tag={true}
data-terra-rollup-tag-show-focus-styles={true}
Expand Down Expand Up @@ -305,9 +297,7 @@ exports[`Rollup Tag should render rollup tag with the label "show less" when isC
>
<Button
aria-atomic="true"
aria-describedby="Terra.tags.hint.rollupTag"
aria-label="Terra.tags.hint.rollupTag"
aria-live="polite"
className="rollup-tag"
data-terra-rollup-tag={true}
data-terra-rollup-tag-show-focus-styles={true}
Expand All @@ -328,10 +318,8 @@ exports[`Rollup Tag should render rollup tag with the label "show less" when isC
>
<button
aria-atomic="true"
aria-describedby="Terra.tags.hint.rollupTag"
aria-disabled={false}
aria-label="Terra.tags.hint.rollupTag"
aria-live="polite"
className="button neutral compact rollup-tag"
data-terra-rollup-tag={true}
data-terra-rollup-tag-show-focus-styles={true}
Expand Down