Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orthonormalize subblocks when multiple species are present #18

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

arthur-lin1027
Copy link
Collaborator

No description provided.

@rosecers
Copy link
Contributor

@arthur-lin1027 have you verified this works?

@arthur-lin1027
Copy link
Collaborator Author

arthur-lin1027 commented Aug 17, 2023

@arthur-lin1027 have you verified this works?

This works, but still need to confirm how to contract the two different species, and to see if it can learn the energies well if it is two different species.

@rosecers
Copy link
Contributor

Is this still active?

@arthur-lin1027
Copy link
Collaborator Author

arthur-lin1027 commented Oct 11, 2023

We should keep this active. Let's talk more on if hstacking features is the correct course of action, and hope that energetics are learned with similar performance given two distinct species vs two of the same species, in the same configuration.

@arthur-lin1027 arthur-lin1027 force-pushed the fix/multiple-species-orthonormalization branch from 70a3452 to 0e138c6 Compare November 14, 2023 01:32
@arthur-lin1027
Copy link
Collaborator Author

arthur-lin1027 commented Nov 14, 2023

@rosecers With your approval, I think this can be merged in. It doesn't affect the behavior of single species, and properly handles when there are multiple species, assuming hstacking is the way to go when we have multiple species (which I think it is).

@arthur-lin1027 arthur-lin1027 merged commit e0d42ef into main Dec 5, 2023
5 checks passed
@arthur-lin1027 arthur-lin1027 deleted the fix/multiple-species-orthonormalization branch December 5, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in orthonormalization code does not handle multiple species properly.
2 participants