Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README #49

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updating README #49

wants to merge 4 commits into from

Conversation

ortengren
Copy link
Collaborator

I adjusted the dependencies section of the README to reflect more accurately the required package versions. I also added the new Rust dependency and included a link to the rustup tool. Lastly, I reordered the document sections so that "Dependencies" comes before "Installation".

@ortengren ortengren linked an issue Sep 30, 2024 that may be closed by this pull request
@arthur-lin1027 arthur-lin1027 self-requested a review October 3, 2024 03:37
@arthur-lin1027
Copy link
Collaborator

@ortengren can you take a look at some of these minor changes here and do one more quick readthrough?

Copy link
Collaborator

@arthur-lin1027 arthur-lin1027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix those small changes!

README.md Outdated

Before installing anisoap, please make sure you have at least the
following packages installed:
* python (3.6 or higher)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version Numbers should be 3.9 or 3.10

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 and higher or strictly 3.9 and 3.10?

Copy link
Collaborator

@arthur-lin1027 arthur-lin1027 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check with different docker file instances

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked that this works with 3.9 and 3.10, either through docker or different conda instances?

README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update readme
2 participants