Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required_status_checks for make, for now #652

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

SgtCoDFish
Copy link
Member

These required_status_checks apply for every branch, which breaks
backports when the job cannot run and succeed. Since the make flow
wasn't available on older branches it cannot pass on those branches.

We remove them for now until the required_status_checks are made
specific to branches where they can succeed. We'll have the opposite
problem to this down the road - we'll want to remove the bazel checks,
but release-1.9 probably won't have bazel.

These required_status_checks apply for every branch, which breaks
backports when the job cannot run and succeed. Since the make flow
wasn't available on older branches it cannot pass on those branches.

We remove them for now until the required_status_checks are made
specific to branches where they can succeed. We'll have the opposite
problem to this down the road - we'll want to remove the bazel checks,
but release-1.9 probably won't have bazel.

Signed-off-by: Ashley Davis <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
@irbekrm
Copy link
Contributor

irbekrm commented Mar 28, 2022

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit e0e96b9 into cert-manager:master Mar 28, 2022
@jetstack-bot
Copy link
Contributor

@SgtCoDFish: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/config.yaml

In response to this:

These required_status_checks apply for every branch, which breaks
backports when the job cannot run and succeed. Since the make flow
wasn't available on older branches it cannot pass on those branches.

We remove them for now until the required_status_checks are made
specific to branches where they can succeed. We'll have the opposite
problem to this down the road - we'll want to remove the bazel checks,
but release-1.9 probably won't have bazel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish SgtCoDFish deleted the remove-required branch March 28, 2022 13:01
@irbekrm
Copy link
Contributor

irbekrm commented Mar 28, 2022

If we implement #653 then these can be enabled again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants