Update constraints and pin mypy #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are finally running. They broke on old versions of Python, but I fixed it and created #101 describing the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constraints hadn't been updated since we added mypy to our dev or tests extras so mypy wasn't pinned and a new release came out yesterday causing our tests to fail. This PR adds mypy to constraints and pins it to the previously working version for now.
Additionally, the constraints file wasn't being used in the tox config for mypy. To fix this, I moved mypy to the test extras and deleted the mypy deps setting in the tox config so it is inherited from the default testenv which uses the constraints file.
I also added quotes around .[dev,tests] because without it zsh complains: