RemoveBlobs command

[ticruz38]

Add a command that will clean up all blobs from the editor content.

It could also be used automatically once a file upload failed, or leave that command up to the user.

[cesardeazevedo]

Thanks, wouldn't a editor.commands.clearContent(true) just be enough to cleanup the whole thing?

[ticruz38]

Thanks, wouldn't a editor.commands.clearContent(true) just be enough to cleanup the whole thing?

Yes I can rename it to clearContent, but the idea is really to remove blobs from the editor for failed or incomplete uploads, which is not the case at the moment.
Not to clean up the whole content. Cleaning up the whole content for a failed upload would be annoying.

[cesardeazevedo]

I actually meant the existing tiptap command clearContent, just curious from a UX perspective to delete failed uploads, usually the user would try to submit again or delete individual ones, but I understand, I would rename it to removeFiles so it matches the other commands in the extension

[staab]

usually the user would try to submit again or delete individual ones, but I understand, I would rename it to removeFiles so it matches the other commands in the extension

Remove files would imply all files, including successful uploads. The idea here is to remove only failed uploads. But maybe a removeFile would be better, so that we're better targeting which specific upload failed, since the current approach could result in removing pending rather than failed uploads if there are multiple concurrent uploads.

[cesardeazevedo]

I agree now and makes sense

[ticruz38]

There is a case, at least in coracle, where we do need to remove all pending uploads, ie when closing a reply and saving a draft.
But for failure handling yes, it might be nice to remove files based on their url or other attributes

[staab]

Maybe removeFile and removePendingFiles then

[cesardeazevedo]

I think removeBlobs are fine