Add leaderboard to staff/admin dashboard #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliciofilipe
temporarily deployed
to
staging
GitHub Actions
Inactive
✅ Deploy Preview for cesium-seium ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is being automatically deployed to Netlify. |
ruilopesm
reviewed
Feb 18, 2023
EnzoVieira
previously requested changes
Feb 18, 2023
✅ Deploy Preview for seium-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ruilopesm
requested review from
EnzoVieira,
tiago-bacelar,
joaodiaslobo and
Darguima
tiago-bacelar
requested changes
Nov 5, 2023
There was a problem hiding this comment.
Since we already have a folder components, I don't think it makes sense to put the leaderboard inside layout/shared
Also, since you removed the navigation field in the manager routes, could you please do the same in all the sponsor routes as well? That way we could remove the navigation argument from the Layout altogether. I think that would be nice :)
Also, the leaderboard link is missing from the landing. It's in components/Navbar/index.jsx.
tiago-bacelar
approved these changes
Nov 6, 2023
ruilopesm
deleted the
ff/387-add-leaderboard-to-staff-admin-dashboards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.