Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove back to sei website text from dashboard #547

Merged

Conversation

maheshchandra10
Copy link
Contributor

Fixes #525

@MarioRodrigues10
Copy link
Member

Hi @maheshchandra10 , thanks for your contribution 🙌
This looks good, but could you please solve the conflits before I approve this.

@diogogmatos
Copy link
Member

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit 958fbc9
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/654f642f8c1f350008ff97a4
😎 Deploy Preview https://deploy-preview-547--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maheshchandra10
Copy link
Contributor Author

Hi @maheshchandra10 , thanks for your contribution 🙌 This looks good, but could you please solve the conflits before I approve this.

Please check now maybe

@MarioRodrigues10
Copy link
Member

MarioRodrigues10 commented Nov 10, 2023

Run npm run format and commit the changes in order to fix CI, and it's all good 🙌

@maheshchandra10
Copy link
Contributor Author

Not sure why the Code Quality check is failing. I took the latest code and ran npm run format and committed, still it fails.

@Darguima
Copy link
Contributor

Darguima commented Nov 10, 2023

Not sure why the Code Quality check is failing. I took the latest code and ran npm run format and committed, still it fails.

What's the output from the command npm run format?

I tried by my self and I could format and commit all the changes without problems.

@maheshchandra10
Copy link
Contributor Author

Not sure why the Code Quality check is failing. I took the latest code and ran npm run format and committed, still it fails.

What's the output from the command npm run format?

I tried by my self and I could format and commit all the changes without problems.

It updated the files which were having formatting issues. I then just committed them and pushed.
You can see the list of changed files in my latest commit.

@ruilopesm ruilopesm added the moonstone Moonstone related label Nov 11, 2023
@ruilopesm ruilopesm self-requested a review November 11, 2023 11:06
@ruilopesm ruilopesm changed the title Remove back to sei website text refactor: remove back to sei website text from dashboard Nov 11, 2023
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help, @maheshchandra10 🙌🏼

@ruilopesm ruilopesm merged commit 6c122f6 into cesium:main Nov 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moonstone Moonstone related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Back to SEI website" text
5 participants