Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hero typing animation #559

Merged
merged 6 commits into from
Nov 9, 2023
Merged

feat: Add hero typing animation #559

merged 6 commits into from
Nov 9, 2023

Conversation

EnzoVieira
Copy link
Member

No description provided.

@EnzoVieira EnzoVieira temporarily deployed to staging October 23, 2023 23:43 — with GitHub Actions Inactive
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text isn't sizing correctly and I think the animation is a bit slow. Maybe the typing mistake should only happen when writing "SAY". 🤔
Other than that awesome work! 💪

image

@EnzoVieira EnzoVieira temporarily deployed to staging October 24, 2023 15:50 — with GitHub Actions Inactive
Copy link
Contributor

@tiago-bacelar tiago-bacelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! Though I think it would look even better with a terminal-like cursor instead of the default one.
Also, I noticed the animation plays every time the mobile navbar opens.

@EnzoVieira EnzoVieira temporarily deployed to staging October 25, 2023 16:38 — with GitHub Actions Inactive
@EnzoVieira
Copy link
Member Author

Really cool! Though I think it would look even better with a terminal-like cursor instead of the default one. Also, I noticed the animation plays every time the mobile navbar opens.

Done ✅

But, the animation will run always when the parent component rerenders. Since the navbar is a parent component and it rerenders when click to open the menu, all it's child components will rerender, as the animation. I tried to save locally if the animation already ran but this causes another issue:
1. If the animation does not already ran: run it ✅
2. If the animation do already ran: the animation will not run again, so the text will no be shawn ❌

So I could not fix this issue 😢. I don't think this will cause big UX/UI problems, this issue only appears if the user clicks to open menu multiple times, so we could keep it and try to refactor the Navbar in another PR.

tiago-bacelar
tiago-bacelar previously approved these changes Oct 26, 2023
Copy link
Contributor

@tiago-bacelar tiago-bacelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.
I do think the animation is a bit slow, though. I noticed you put it faster in your previous commit and then slowed it back down. Although it's cool on a first viewing, I feel like it could get boring on repeated viewings at the current speed. (We could always save on local cache whether the user already saw it multiple times :)

@EnzoVieira
Copy link
Member Author

Seems good. I do think the animation is a bit slow, though. I noticed you put it faster in your previous commit and then slowed it back down. Although it's cool on a first viewing, I feel like it could get boring on repeated viewings at the current speed. (We could always save on local cache whether the user already saw it multiple times :)

sorry 😅, it was my mistake change the animation duration again when I were debuggin yesterday. But I changed it back again!

@MarioRodrigues10
Copy link
Member

I'm using firefox and these animation looks kinda fast, so could you slow it a little bit more?

@tiago-bacelar
Copy link
Contributor

I'm on firefox too, I think the speed is fine. Maybe it could be slightly tweaked, but slowing it too much would make it boring and, honestly, I don't think it would be noticeably better.

tiago-bacelar
tiago-bacelar previously approved these changes Nov 2, 2023
@EnzoVieira EnzoVieira temporarily deployed to staging November 2, 2023 13:30 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 2, 2023

This pull request is being automatically deployed to Netlify.

✅ Preview: https://deploy-preview-559--seium.netlify.app/

Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 🤩

@MarioRodrigues10 MarioRodrigues10 dismissed stale reviews from tiago-bacelar and themself via a8e22b0 November 9, 2023 00:20
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit a8e22b0
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/654c25ec26dd50000822f808
😎 Deploy Preview https://deploy-preview-559--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tiago-bacelar tiago-bacelar merged commit a74b6b4 into main Nov 9, 2023
5 checks passed
@tiago-bacelar tiago-bacelar deleted the ev/typing-animation branch November 9, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants