-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add hero typing animation #559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool! Though I think it would look even better with a terminal-like cursor instead of the default one.
Also, I noticed the animation plays every time the mobile navbar opens.
Done ✅ But, the animation will run always when the parent component rerenders. Since the navbar is a parent component and it rerenders when click to open the menu, all it's child components will rerender, as the animation. I tried to save locally if the animation already ran but this causes another issue: So I could not fix this issue 😢. I don't think this will cause big UX/UI problems, this issue only appears if the user clicks to open menu multiple times, so we could keep it and try to refactor the Navbar in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
I do think the animation is a bit slow, though. I noticed you put it faster in your previous commit and then slowed it back down. Although it's cool on a first viewing, I feel like it could get boring on repeated viewings at the current speed. (We could always save on local cache whether the user already saw it multiple times :)
sorry 😅, it was my mistake change the animation duration again when I were debuggin yesterday. But I changed it back again! |
I'm using firefox and these animation looks kinda fast, so could you slow it a little bit more? |
I'm on firefox too, I think the speed is fine. Maybe it could be slightly tweaked, but slowing it too much would make it boring and, honestly, I don't think it would be noticeably better. |
This pull request is being automatically deployed to Netlify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job 🤩
a8e22b0
✅ Deploy Preview for seium-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
No description provided.