Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply select-none to all titles and buttons #593

Merged
merged 4 commits into from
Dec 7, 2023
Merged

feat: apply select-none to all titles and buttons #593

merged 4 commits into from
Dec 7, 2023

Conversation

joaodiaslobo
Copy link
Member

@joaodiaslobo joaodiaslobo commented Dec 5, 2023 •
edited
Loading

Fix #502, the page should feel way better in this aspect

@joaodiaslobo joaodiaslobo self-assigned this Dec 5, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit db950fa
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/6571051a24ee1000083456b1
😎 Deploy Preview https://deploy-preview-593--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joaodiaslobo
Copy link
Member Author

feat: apply select-none to all titles and buttons

Darguima
Darguima requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Darguima Darguima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The side bar has its entries selectable.

image

And all pages that are accessible from there have also content that shouldn't be selectable. (Remember that staff and attendees have access to different pages)

Ex:
Profile page titles and images (like the avatar)
image

@Darguima
Copy link
Contributor

Darguima commented Dec 7, 2023

Perfect!

@joaodiaslobo joaodiaslobo merged commit 96c1c7e into main Dec 7, 2023
5 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/disallow-title-selection branch December 7, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darguima Darguima Darguima approved these changes

@ruioliveira02 ruioliveira02 Awaiting requested review from ruioliveira02

@tiago-bacelar tiago-bacelar Awaiting requested review from tiago-bacelar

@EnzoVieira EnzoVieira Awaiting requested review from EnzoVieira

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

@MarioRodrigues10 MarioRodrigues10 Awaiting requested review from MarioRodrigues10

Assignees

@joaodiaslobo joaodiaslobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply select-none to each title
2 participants
@joaodiaslobo @Darguima