Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: normalize profile mentions #604

Merged
merged 4 commits into from
Jan 16, 2024
Merged

feat: normalize profile mentions #604

merged 4 commits into from
Jan 16, 2024

Conversation

MarioRodrigues10
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 commented Dec 17, 2023 •
edited
Loading

This PR depends on cesium/safira#361

@netlify Netlify
Copy link

netlify bot commented Dec 17, 2023 •
edited
Loading

✅ Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit a224035
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/65a6bca405ea540008dfef00
😎 Deploy Preview https://deploy-preview-604--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MarioRodrigues10 MarioRodrigues10 mentioned this pull request Dec 17, 2023
Merged
@MarioRodrigues10 MarioRodrigues10 linked an issue Dec 17, 2023 that may be closed by this pull request
Normalize all profiles mentions #499
Closed
joaodiaslobo
joaodiaslobo requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the profile mentions in this page:

image

@MarioRodrigues10
Copy link
Member Author

You forgot the profile mentions in this page:

image

Previously that wasn't clickable.

@joaodiaslobo
Copy link
Member

@MarioRodrigues10
The issue says:

"Every time a mention to a user profile appears, there should be an hyperlink to his profile."

In order to fix this issue, as you are trying with this PR, you need to make sure every time a user is mentioned it has an hyperlink to their profile even if it wasn't previously possible.

@MarioRodrigues10
Copy link
Member Author

@MarioRodrigues10 The issue says:

"Every time a mention to a user profile appears, there should be an hyperlink to his profile."

In order to fix this issue, as you are trying with this PR, you need to make sure every time a user is mentioned it has an hyperlink to their profile even if it wasn't previously possible.

Ohh alright, i will look into that , thanks 🙏

joaodiaslobo
joaodiaslobo requested changes Jan 16, 2024
View reviewed changes
layout/Attendees/Attendees.tsx Outdated Show resolved Hide resolved
@joaodiaslobo joaodiaslobo self-requested a review January 16, 2024 17:28
joaodiaslobo
joaodiaslobo approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤘

@MarioRodrigues10 MarioRodrigues10 merged commit ee42771 into main Jan 16, 2024
5 checks passed
@MarioRodrigues10 MarioRodrigues10 deleted the mr/normalize-profile-mentions branch January 16, 2024 17:30
MarioRodrigues10
MarioRodrigues10 commented Apr 18, 2024
View reviewed changes
Copy link
Member Author

@MarioRodrigues10 MarioRodrigues10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaodiaslobo joaodiaslobo joaodiaslobo approved these changes

@ruioliveira02 ruioliveira02 Awaiting requested review from ruioliveira02

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

@Darguima Darguima Awaiting requested review from Darguima

@tiago-bacelar tiago-bacelar Awaiting requested review from tiago-bacelar

@EnzoVieira EnzoVieira Awaiting requested review from EnzoVieira

Assignees

@MarioRodrigues10 MarioRodrigues10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize all profiles mentions
2 participants
@MarioRodrigues10 @joaodiaslobo