Embedded Atom Method Potential #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Sutton-Chen formulation.
|
Just following up with this pull request, was there any interest in merging this? If not I'll close. State seems to diverge/conflict with base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This pull request serves as an initial attempt to implement the EAM style potential within this package. In particular, the focus was on the formulation by Finnis and Sinclair to enable use in the composable workflows guide. This should be easily extendable towards tabulated/interpolated styles, if needed.
Tests/Support
At the moment, the function calls execute and interface with API.
The force balance appears correct, however, the expected energies (forces?) do not seem to be correct for the used parameter set. Additional review of implementation for correctness is needed and much appreciated.