Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add auth.oidc.preferredJwsalgorithm param #306

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

happy-code-com
Copy link
Contributor

@happy-code-com happy-code-com commented Jun 12, 2023

Which issue this PR fixes

  • Added templating "nifi.security.user.oidc.preferred.jwsalgorithm" property as "auth.oidc.preferredJwsalgorithm" value

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md

Copy link
Contributor

@banzo banzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, I'd suggest to change the option's case to preferredJwsAlgorithm to increase readability.

@banzo banzo added the enhancement New feature or request label Jun 13, 2023
@happy-code-com
Copy link
Contributor Author

I will try to figure out what the problem is with the tests and make corrections.

@banzo
Copy link
Contributor

banzo commented Jun 15, 2023

It might just be limits on container pulls or resources that GitHub enforces.

@banzo
Copy link
Contributor

banzo commented Jun 20, 2023

nope, the OIDC tests seem to be broken.
If you have an idea on how to fix them, you are more welcome to share it :)

@happy-code-com
Copy link
Contributor Author

Hmm. interestingly, in fact nothing was added, just an empty string started to be passed from the parameters... I'll try to think what could be the matter 🤯

@wknickless
Copy link
Contributor

I'm seeing this error in the OIDC Insecure test when fast-forwarding my personal fork from the master branch. Not sure yet what "Error: Timeout cleared" means, but it smells like a change in behavior either in Puppeteer or an underlying node.js component. Investigating further.

Run export K8SNODEIP=$(kubectl get node -o json | jq -r '.items[0].status.addresses[0].address')
  


  NiFi Login via OIDC
    ✔ NiFi redirects to KeyCloak login page (3600ms)
    ✔ Get screenshot of Keycloak login page (87ms)
    1) [email protected] shown as logged in user
    ✔ Get screenshot of logged in user (643ms)


  3 passing (6s)
  1 failing

  1) NiFi Login via OIDC
       [email protected] shown as logged in user:
     Error: Timeout cleared
      at Deferred.race (node_modules/puppeteer-core/lib/cjs/puppeteer/util/Deferred.js:94:33)
      at async CDPPage._waitForNetworkIdle (node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:567:9)
      at async CDPPage.waitForNetworkIdle (node_modules/puppeteer-core/lib/cjs/puppeteer/common/Page.js:482:9)
      at async Promise.all (index 2)
      at async Context.<anonymous> (work/helm-nifi/helm-nifi/tests/04-oidc-login-test.js:20:[17](https://github.com/wknickless/helm-nifi/actions/runs/5324729729/jobs/9644451370#step:9:18))



Error: Process completed with exit code 1.

@wknickless
Copy link
Contributor

Looks like we may be running into puppeteer/puppeteer#10398 .

@banzo
Copy link
Contributor

banzo commented Aug 8, 2023

closing so that reopening will retrigger all the checks

@banzo banzo closed this Aug 8, 2023
@banzo banzo reopened this Aug 8, 2023
@banzo banzo merged commit 09dac85 into cetic:master Aug 8, 2023
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants