-
Notifications
You must be signed in to change notification settings - Fork 227
Add auth.oidc.preferredJwsalgorithm param #306
Conversation
…ed.jwsalgorithm={{.Values.auth.oidc.preferredJwsalgorithm}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, I'd suggest to change the option's case to preferredJwsAlgorithm
to increase readability.
I will try to figure out what the problem is with the tests and make corrections. |
It might just be limits on container pulls or resources that GitHub enforces. |
nope, the OIDC tests seem to be broken. |
Hmm. interestingly, in fact nothing was added, just an empty string started to be passed from the parameters... I'll try to think what could be the matter 🤯 |
I'm seeing this error in the OIDC Insecure test when fast-forwarding my personal fork from the master branch. Not sure yet what "Error: Timeout cleared" means, but it smells like a change in behavior either in Puppeteer or an underlying node.js component. Investigating further.
|
Looks like we may be running into puppeteer/puppeteer#10398 . |
closing so that reopening will retrigger all the checks |
Which issue this PR fixes
Checklist