Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of the mesh generation and control pt. 1 #280

Merged
merged 50 commits into from
Dec 5, 2023

Conversation

GBenedett
Copy link
Collaborator

@GBenedett GBenedett commented May 4, 2023

Objective:

  • Change the power law to mesh the fluid domain
  • Add the feature in CEASIOMpy GUI
  • Scale the mesh proportionally to the size of the aircraft (farfield, wing and fuselage)
  • Improved the sumo geometry generation
  • Switch from cell size to cell factor proportional to aircraft dimensions
  • Automatic Aeromap creation (if there isn't in CPACS file)
  • Directional refinement or local (specific aircraft part) refinement

@GBenedett GBenedett changed the title power value in domain mesh changed Improvement of the refinement of the mesh in the fluid domain May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (0fdd6dc) 68.99% compared to head (cf7dce6) 69.47%.
Report is 5 commits behind head on main.

Files Patch % Lines
ceasiompy/CPACS2GMSH/func/mesh_sizing.py 88.37% 20 Missing ⚠️
ceasiompy/SU2Run/func/su2config.py 46.42% 15 Missing ⚠️
ceasiompy/CPACS2SUMO/cpacs2sumo.py 50.00% 10 Missing ⚠️
ceasiompy/SkinFriction/skinfriction.py 0.00% 3 Missing ⚠️
ceasiompy/ExportCSV/exportcsv.py 50.00% 2 Missing ⚠️
ceasiompy/SUMOAutoMesh/sumoautomesh.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   68.99%   69.47%   +0.47%     
==========================================
  Files          82       84       +2     
  Lines        7906     8148     +242     
==========================================
+ Hits         5455     5661     +206     
- Misses       2451     2487      +36     
Flag Coverage Δ
integrationtests 54.61% <80.22%> (-1.37%) ⬇️
unittests 50.94% <72.10%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GBenedett GBenedett added Python Related to Python GMSH Related to GMSH labels May 4, 2023
@GBenedett GBenedett added the SUMO Related to SUMO label Oct 3, 2023
@GBenedett GBenedett changed the title Improvement of the refinement of the mesh in the fluid domain Improvement of the refinement of the mesh in the fluid domain pt. 1 Dec 4, 2023
@GBenedett GBenedett changed the title Improvement of the refinement of the mesh in the fluid domain pt. 1 Improvement of the mesh generation and control pt. 1 Dec 4, 2023
@GBenedett GBenedett merged commit a11eb44 into main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GMSH Related to GMSH Python Related to Python SUMO Related to SUMO
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant