-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sync] 2021/02/11 #257
Merged
Merged
[sync] 2021/02/11 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes according to discussion in #2799. Closes #2799.
Remove references to long-dead language versions. At this point, there's no need to document features added in 2.3 or call out that async keywords aren't supported in Dart 1.x :)
Fixes #2812
Update the shared-packages tutorial in commands in Libraries to use the new `dart` tool
Co-authored-by: Kathy Walrath <[email protected]>
Update the "Write HTTP clients & servers" tutorial to use the new `dart` tool
* migrated examples/util/ to null_safety_examples/util/ * migrated examples/iterables/ to null_safety_examples/iterables/ * copy analysis_options from examples to null_safety_examples * point iterables analysis_options to null_safety_examples analysis_options
* Copy of original async-await examples and codelab * migrated async_await example to null safety * Codelab migration to null safety - removed iframe dart-pad integration - code excerpts link to null_safety_examples/async_await - enabled null safety on dartpad examples - migrated practice_using dartpad exercise - migrate practice_error to null safety - add empty changeUsername to avoid 'undefined name' error - migrate putting_it_all_together to null safety * add missing test yaml files
Updated src/tools/build_runner.md to use new dart tools
Added missing space to make it "link text" rather than "linktext"
Add Discord link
Co-authored-by: Kathy Walrath <[email protected]>
Co-authored-by: Kathy Walrath <[email protected]>
Just a nice suggestion so it's less likely to overwrite any other commands you have on the system.
* replace dart format with dartfmt * Apply suggestions from code review Co-authored-by: Kathy Walrath <[email protected]>
Co-authored-by: Kathy Walrath <[email protected]>
Holy moly |
AlexV525
reviewed
Feb 7, 2021
- 新增 Language samples 需要翻译 src/samples/index_migrated.md
AlexV525
reviewed
Feb 11, 2021
Closed
AlexV525
reviewed
Feb 15, 2021
@@ -0,0 +1,408 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这篇我怀疑跟 sample/index 一样,不知道为什么抽出来了,名字上意思是已迁移的。FYI @chenglu
AlexV525
reviewed
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #123
新增文档: