Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(develop): HTTP/2 error: Stream error #486 #1437

Closed
wants to merge 1 commit into from

Conversation

xrr2016
Copy link
Contributor

@xrr2016 xrr2016 commented Mar 4, 2022

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest develop to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass

This merge request fixes / refers to the following issues: ...

Pull Request Description

Fix DioError [DioErrorType.DEFAULT]: HTTP/2 error: Stream error: Stream was terminated by peer (errorCode: 1)

Ref

dart-lang/http#1361

#486

@itsbalamurali
Copy link

@ueman @kuhnroyal can you please review this and merge it?

@Nobler
Copy link

Nobler commented May 25, 2022

@xrr2016 Hi, please check the issue I fired before. The real issue that should be fixed is here. It is not the issue about http2, but Options.

@Nobler
Copy link

Nobler commented May 25, 2022

By the way, some unit tests should be added for sure.

@SahajRana
Copy link

This PR does not resolve the issue from what I can see.

@AlexV525
Copy link
Member

Hi everyone! We've made our hardfork repo public and published a new version of dio, named diox.
The new package contains the PR of the fix.
Please refer to https://pub.dev/packages/diox/versions/5.0.0-dev.1 to use the fork.
You can also see why we're working for a hardfork at cfug/diox#29 and #1607.

@AlexV525 AlexV525 closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants