🐛 Only produce null response body when the response is a JSON type #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
commented
Jun 17, 2023
| }, | ||
| onDone: () => completer.complete(), | ||
| cancelOnError: true, | ||
| ); | ||
| options.cancelToken?.whenCancel.then((_) { | ||
| return subscription.cancel(); |
There was a problem hiding this comment.
I wasn't sure about how this line will behave (whether we should complete the completer or not). It's a void future and we await for the completer in the outside scope.
bgenidy
reviewed
Jun 25, 2023
AlexV525
changed the title
ResponseType.json
|
cc @kuhnroyal @ueman |
kuhnroyal
approved these changes
Jul 9, 2023
…pe-json # Conflicts: # dio/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1834.
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding package