Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework exceptions and stacktraces #1963

Draft
wants to merge 1 commit into
base: 6.0.0
Choose a base branch
from
Draft

Rework exceptions and stacktraces #1963

wants to merge 1 commit into from

Commits on Sep 11, 2023

  1. Initial exception/stacktrace rework 

    * rename `DioException.error` to `DioException.cause`
* add `DioException.causeStackTrace`
* get rid of `RequestOptions.sourceStackTrace` property
* use `Error.throwWithStackTrace` to throw all errors with the manually captured stack trace at a single point in `DioMixin`
* extract some inner functions inside `DioMixin.fetch` to prevent them capturing the state of `requestOptions` and `cancelToken` variables, instead pass them as arguments
    @kuhnroyal
    kuhnroyal committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7276db0 View commit details
    Browse the repository at this point in the history