Attempt to fix WASM compile errors #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
reviewed
Jul 4, 2024
Signed-off-by: Alex Li <[email protected]>
AlexV525
approved these changes
Jul 4, 2024
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what understand, we added conditional
js_interopimports that forcedart:htmlimports into WASM builds.Since we don't yet support WASM, I don't completely understand how it actually compiled to WASM before change.
For now we can just remove the conditional imports and add them back together with actual WASM support.
Hopefully fixes #2266
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)