Fix some functions when using cgreen with its namespace in C++. #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Using cgreen for C++ without including
using namespace cgreen
in the code results in compilation errors when one attempts to usecgreen::assert_that()
.I just prefixed some things with
cgreen::
and addednamespace cgreen {
where appropriate.The changes from this patch fixed the parts of cgreen I utilized but I haven't been able to test everything in cgreen.
Ideally I wanted to add the cgreen namespace to
TestSuite
ininclude/cgreen/internal/suite_internal.h
as well but since that hasnamespace cgreen {
later, I take it there was a good reason not to add TestSuite to the cgreen namespace.Those who are applying
using namespace cgreen
to get around the compilation error should see no difference.