Fix issue where iPhone with 5.5 inch display is not detected and deviceSize returns UnknownSize. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constantine-fry
changed the title
|
Thanks! I'm going to test this ASAP and merge if all looks good. |
|
Have you tested this on an actual device? I don't have a plus available to me, but 2208 seems to be the right value according to the simulator. |
|
Hi, Sorry for the late response. I seems to be an expected behaviour: |
|
Hrm... any chance you have a real device to test on though? |
|
Sorry, i'd just like to prove it before approval, otherwise things can go quickly sideways :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.paintcodeapp.com/news/iphone-6-screens-demystified