Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filters] Add missing group argument on update filter route #704

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[filters] Add missing group argument on update filter route #704

merged 1 commit into from
Sep 15, 2023

Conversation

NicoPennec
Copy link
Member

Problem

  • The endpoint for updating a filter fails to save the group id.

Solution

  • Add the missing argument to the route declaration.

@NicoPennec NicoPennec marked this pull request as draft September 15, 2023 12:58
@frankrousseau frankrousseau marked this pull request as ready for review September 15, 2023 13:32
@frankrousseau frankrousseau merged commit f1a00a2 into cgwire:master Sep 15, 2023
4 checks passed
@NicoPennec NicoPennec deleted the fix/update-filter branch September 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicoPennec @frankrousseau