Skip to content

Commit

Permalink
Fix previous commit "Remove duplicate code"
Browse files Browse the repository at this point in the history
* exwm-layout.el (exwm-layout-unset-fullscreen):
`xcb:Atom:_NET_WM_STATE_FULLSCREEN' must be excised before
invoking `exwm-layout--show'.
  • Loading branch information
medranocalvo committed Nov 10, 2021
1 parent 5098708 commit 08f20ea
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions exwm-layout.el
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,11 @@
(exwm-layout--fullscreen-p))
(cl-return-from exwm-layout-unset-fullscreen))
(with-current-buffer (if id (exwm--id->buffer id) (window-buffer))
;; `exwm-layout--show' relies on `exwm--ewmh-state' to decide whether to
;; fullscreen the window.
(setq exwm--ewmh-state
(delq xcb:Atom:_NET_WM_STATE_FULLSCREEN exwm--ewmh-state))
(exwm-layout--set-ewmh-state exwm--id)
(if exwm--floating-frame
(exwm-layout--show exwm--id (frame-root-window exwm--floating-frame))
(xcb:+request exwm--connection
Expand All @@ -231,9 +236,6 @@
(let ((window (get-buffer-window nil t)))
(when window
(exwm-layout--show exwm--id window))))
(setq exwm--ewmh-state
(delq xcb:Atom:_NET_WM_STATE_FULLSCREEN exwm--ewmh-state))
(exwm-layout--set-ewmh-state exwm--id)
(xcb:flush exwm--connection)
(set-window-dedicated-p (get-buffer-window) nil)
(when (eq 'line-mode exwm--selected-input-mode)
Expand Down

0 comments on commit 08f20ea

Please sign in to comment.