Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LUD-VAE #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for LUD-VAE #253

wants to merge 1 commit into from

Conversation

RunDevelopment
Copy link
Member

Not sure if this will be useful for spandrel to support. Inference tests don't work yet, but detection and loading does.

@joeyballentine
Copy link
Member

Do you want help fixing the inference tests?

@RunDevelopment
Copy link
Member Author

Sure, that would be nice. My main issue is that I don't know how LUD-VAE is supposed to be used and didn't have the time to look into that yet. Does our image -> image call API even make sense for LUD-VAE?

@joeyballentine
Copy link
Member

I'm not really sure what LUD-VAE even is. Skimming the repo made it seem like a denoiser

@RunDevelopment
Copy link
Member Author

It's the opposite: it adds noise. The arch is supposed to learn the noise of some input images to generated noisy datasets for training models.

@joeyballentine
Copy link
Member

Interesting. Well if it's just clean -> noisy then our call API should work fine, no?

@RunDevelopment
Copy link
Member Author

RunDevelopment commented May 17, 2024

I saw some stuff suggesting that LUD-VAE is parameterized at inference time, so I'm not sure where image -> image will work. But again, I haven't looked into it yet.

@joeyballentine
Copy link
Member

We might have to make a new model descriptor type for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants