Simplified PLKSR #255
Merged
Simplified PLKSR #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make review comments, but there was a lot of small things, so I just quickly did them myself.
In general, I made the code less defensive. You almost always checked whether a key was present in the state dict before accessing it. This is entirely unnecessary, because we assume that the state dicts
loadgets are valid. So they aren't missing any important keys. If they were missing any such keys, then they'd be invalid and we'd be allowed to just fail.Using this assumption, I simplified some code.
Other changes:
n_blocksas create before the real value was assigned.