Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESRGAN loading + add more community model tests #27

Merged
merged 2 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/spandrel/__helpers/main_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ def _detect(state_dict: StateDict) -> bool:
_has_keys(
"model.0.weight",
"model.1.sub.0.RDB1.conv1.0.weight",
"model.2.weight",
"model.4.weight",
)(state)
or _has_keys(
"conv_first.weight",
Expand Down
45 changes: 45 additions & 0 deletions tests/__snapshots__/test_ESRGAN.ambr
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,51 @@
]),
)
# ---
# name: test_ESRGAN_community_2x
SRModelDescriptor(
architecture='ESRGAN',
input_channels=3,
output_channels=3,
scale=2,
size_requirements=SizeRequirements(minimum=None, multiple_of=None, square=False),
supports_bfloat16=True,
supports_half=True,
tags=list([
'64nf',
'23nb',
]),
)
# ---
# name: test_ESRGAN_community_4x
SRModelDescriptor(
architecture='ESRGAN',
input_channels=3,
output_channels=3,
scale=4,
size_requirements=SizeRequirements(minimum=None, multiple_of=None, square=False),
supports_bfloat16=True,
supports_half=True,
tags=list([
'32nf',
'12nb',
]),
)
# ---
# name: test_ESRGAN_community_8x
SRModelDescriptor(
architecture='ESRGAN',
input_channels=3,
output_channels=3,
scale=8,
size_requirements=SizeRequirements(minimum=None, multiple_of=None, square=False),
supports_bfloat16=True,
supports_half=True,
tags=list([
'64nf',
'23nb',
]),
)
# ---
# name: test_RealESRGAN_x2plus
SRModelDescriptor(
architecture='ESRGAN',
Expand Down
Binary file added tests/images/outputs/16x16/2x-BIGOLDIES.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/16x16/4x-NMKD-YandereNeo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/16x16/8x-ESRGAN.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/32x32/2x-BIGOLDIES.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/32x32/4x-NMKD-YandereNeo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/32x32/8x-ESRGAN.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/64x64/2x-BIGOLDIES.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/64x64/4x-NMKD-YandereNeo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/64x64/8x-ESRGAN.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/8x8/2x-BIGOLDIES.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/8x8/4x-NMKD-YandereNeo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added tests/images/outputs/8x8/8x-ESRGAN.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
42 changes: 42 additions & 0 deletions tests/test_ESRGAN.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,48 @@ def test_ESRGAN_community(snapshot):
)


def test_ESRGAN_community_2x(snapshot):
file = ModelFile.from_url(
"https://objectstorage.us-phoenix-1.oraclecloud.com/n/ax6ygfvpvzka/b/open-modeldb-files/o/2x-BIGOLDIES.pth"
)
model = ModelLoader().load_from_file(file.path)
assert model == snapshot(exclude=disallowed_props)
assert isinstance(model.model, RRDBNet)
assert_image_inference(
file,
model,
[TestImage.SR_8, TestImage.SR_16, TestImage.SR_32, TestImage.SR_64],
)


def test_ESRGAN_community_4x(snapshot):
file = ModelFile.from_url(
"https://objectstorage.us-phoenix-1.oraclecloud.com/n/ax6ygfvpvzka/b/open-modeldb-files/o/4x-NMKD-YandereNeo.pth"
)
model = ModelLoader().load_from_file(file.path)
assert model == snapshot(exclude=disallowed_props)
assert isinstance(model.model, RRDBNet)
assert_image_inference(
file,
model,
[TestImage.SR_8, TestImage.SR_16, TestImage.SR_32, TestImage.SR_64],
)


def test_ESRGAN_community_8x(snapshot):
file = ModelFile.from_url(
"https://objectstorage.us-phoenix-1.oraclecloud.com/n/ax6ygfvpvzka/b/open-modeldb-files/o/8x-ESRGAN.pth"
)
model = ModelLoader().load_from_file(file.path)
assert model == snapshot(exclude=disallowed_props)
assert isinstance(model.model, RRDBNet)
assert_image_inference(
file,
model,
[TestImage.SR_8, TestImage.SR_16, TestImage.SR_32, TestImage.SR_64],
)


def test_BSRGAN(snapshot):
file = ModelFile.from_url(
"https://github.com/cszn/KAIR/releases/download/v1.0/BSRGAN.pth"
Expand Down