Improved parameter detection for Compact #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pixelshuffle_shape
parameter. We are now using the exact model code from the Real-ESRGAN repo.The new detection code is actually pretty simple: we just brute force it. We know that the number
x
we read from the state dict isx = scale * scale * out_nc
. We also know thatout_nc
is either 1, 3, or 4. So we just have to try out all possible values forout_nc
see which one fulfills the formula forx
.Unfortunately, this method does not work correctly when the actual number of output channels is 1 or 4, because 1 and 4 are square numbers. E.g. for
scale=3
andout__nc=4
we getx=36
, butscale=6
andout_nc=1
also producesx=36
. To fix this, we make the assumption thatout_nc=in_nc
is likely. E.g. ifin_nc=4
, we will preferout_nc=4
overout_nc=1
.