Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RealPLKSR DySample #293

Merged
merged 7 commits into from
Jul 13, 2024
Merged

Add support for RealPLKSR DySample #293

merged 7 commits into from
Jul 13, 2024

Conversation

joeyballentine
Copy link
Member

Closes #275

RunDevelopment
RunDevelopment reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These SR images look wrong. Does the model you tested produce these results with the original arch code too?

libs/spandrel/spandrel/architectures/PLKSR/__arch/RealPLKSR.py Show resolved Hide resolved
@joeyballentine
Copy link
Member Author

joeyballentine commented Jul 13, 2024 •
edited
Loading

The output is correct. LR and the SR GT were taken from this
image

@RunDevelopment RunDevelopment merged commit 7d4923b into main Jul 13, 2024
8 checks passed
@RunDevelopment RunDevelopment deleted the plksr_dysample branch July 13, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for RealPLKSR DySample
2 participants
@joeyballentine @RunDevelopment