Refactorings + Tests #9
Annotations
10 errors and 11 warnings
GolangCI-Lint:
config/config.go#L92
Error return value of `viper.ReadInConfig` is not checked (errcheck)
|
GolangCI-Lint:
internal/rpc/server/server.go#L106
Error return value of `s.grpcServer.Serve` is not checked (errcheck)
|
GolangCI-Lint:
internal/rpc/server/server.go#L193
Error return value of `grpc.SendHeader` is not checked (errcheck)
|
GolangCI-Lint:
internal/matrix/matrix_decompressor.go#L38
Error return value of `msg.UnmarshalContent` is not checked (errcheck)
|
GolangCI-Lint:
internal/app/app.go#L38
Error return value of `logger.Sync` is not checked (errcheck)
|
GolangCI-Lint:
config/config.go#L53
commentFormatting: put a space between `//` and comment text (gocritic)
|
GolangCI-Lint:
internal/rpc/client/client.go#L45
exitAfterDefer: log.Fatalf will exit, and `defer rc.mu.Unlock()` will not run (gocritic)
|
GolangCI-Lint:
internal/messaging/processor.go#L143
commentFormatting: put a space between `//` and comment text (gocritic)
|
GolangCI-Lint:
internal/messaging/processor.go#L156
commentFormatting: put a space between `//` and comment text (gocritic)
|
GolangCI-Lint:
internal/messaging/processor.go#L180
commentFormatting: put a space between `//` and comment text (gocritic)
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
GolangCI-Lint:
config/flags.go#L26
var-naming: func readPartnerRpcServerConfig should be readPartnerRPCServerConfig (revive)
|
GolangCI-Lint:
internal/messaging/processor.go#L119
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
GolangCI-Lint:
internal/messaging/service.go#L189
unused-parameter: parameter 'opts' seems to be unused, consider removing or renaming it as _ (revive)
|
GolangCI-Lint:
internal/rpc/server/server.go#L69
unexported-return: exported func NewServer returns unexported type *server.server, which can be annoying to use (revive)
|
GolangCI-Lint:
internal/rpc/server/server.go#L196
error-return: error should be the last type when returning multiple items (revive)
|
GolangCI-Lint:
internal/app/app.go#L88
context-as-argument: context.Context should be the first parameter of a function (revive)
|
GolangCI-Lint:
internal/app/app.go#L105
context-as-argument: context.Context should be the first parameter of a function (revive)
|
GolangCI-Lint:
internal/app/app.go#L124
context-as-argument: context.Context should be the first parameter of a function (revive)
|
GolangCI-Lint:
internal/matrix/matrix_compressor.go#L25
exported: type name will be used as matrix.MatrixChunkingCompressor by other packages, and that stutters; consider calling this ChunkingCompressor (revive)
|
GolangCI-Lint:
internal/matrix/matrix_messenger.go#L46
unexported-return: exported func NewMessenger returns unexported type *matrix.messenger, which can be annoying to use (revive)
|
Loading