Introduce New Protobuf Definitions for Seat Mapping #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diagram for the new message types
|
SamJaarsma
requested changes
May 7, 2024
SamJaarsma
requested changes
May 8, 2024
refactor availability message names to inventory update availability service with different identifiers
- SeatInventory updated to be a a list of seat_ids - SectionInventory now contains a oneof field of seats that has seat_inventory and seat_counts fields. - SeatCounts msg type contains total and remaining seat counts
- validation messages now uses the validation object and search identifier - this removes redundant code and makes it simpler
Noctunus
reviewed
May 14, 2024
- comments updated/improved - SeatMapLocation renamed to SeatLocation - image_urls replaced with the Image type from file.proto - remaining_seats renamed to seat_count for availability & seat selection - helper types moved to the end of the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new set of Protobuf definitions designed for detailed and flexible seat mapping in systems such as event ticketing or transportation booking.
New Features Include:
Seat and Feature Representation: Introduced
SeatandSeatAttributemessages whereSeatAttributeincludesname,description, and avaluefor dynamic attributes like age restrictions or special conditions. This structured approach allows for more detailed descriptions and easier management of seat features and restrictions.Improved Location Handling: The
SeatLocationmessage supports both SVG and bitmap representations, facilitating precise seat placement on various types of seat maps.Section and Seat Map Structuring: The
Sectionmessage has been enhanced with recursive capabilities, allowing sections to contain inner sections. This is particularly useful for complex venues with multiple nested areas, such as stadiums or large theaters.SeatMapnow incorporates the recursiveSectionstructure and a localized description set, improving the map's comprehensiveness and usability.Availability & Selection: Introduced
SeatInventory,SectionInventory,SeatMapInventorymessages for representing seat inventory, linked recursively to accommodate complex hierarchical structures of venues (same as theSeatMap). These will be used for seat availability and seat selection messages. Pricing is not included here, it will be in the offers (product search results).SeatMap & Availability Service: Introduced a simple seat map and seat map availability service in a new package. (Because they will be used by multiple services across different packages like transport and activities)
Technical Specifications:
SeatMapmessage type is structured to serve as a repository for static data, such as the layout and structural details of seat arrangements. It does not manage dynamic information like seat availability or pricing.