Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated directives and Localized fields #23

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

VjeraTurk
Copy link
Contributor

@VjeraTurk VjeraTurk commented Aug 9, 2024

#628

  • LocalizedDescriptionSet renamed to LocalizedDescriptions
    Multilingual:
  • Added in the SeatMapRequest a repeated language field
  • In the response made LocalizedDescriptions a repeated field (to cater for all languages requested)*
  • CountryEntryRequirementCategory, the Items made a repeated field
    Localized descriptions
  • SeatAttribute, group name and destription into a new message and add the language so that we can insert it in SeatAttribute with a repeated -> made it like LocalizedDescriptionSet, where language is not part of the message but a part of set
  • For section name used existing LocalizedString type

* should bot or "final system" filter the languages for the response?

@VjeraTurk VjeraTurk changed the title Fix repeated directives Fix repeated directives and Localized fields Aug 9, 2024
@VjeraTurk VjeraTurk requested a review from mo-c4t August 9, 2024 08:04
@VjeraTurk VjeraTurk self-assigned this Aug 9, 2024
@VjeraTurk VjeraTurk marked this pull request as ready for review August 9, 2024 09:17
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we keep CMP.types...LocalizedDescriptionSet message, because we think it is used elsewhere. Only the fieldname is changed localized_descriptions

@VjeraTurk VjeraTurk merged commit 0ea2dfb into dev Aug 12, 2024
3 checks passed
@havan havan deleted the VjeraTurk/fix-repeated-directives branch August 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants