Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MintService v2 #33

Merged
merged 10 commits into from
Sep 23, 2024
Merged

MintService v2 #33

merged 10 commits into from
Sep 23, 2024

Conversation

mo-c4t
Copy link
Member

@mo-c4t mo-c4t commented Sep 17, 2024

  • Renaming BookingToken to Token
  • use token id and token uri in mint request

Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mo-c4t mo-c4t requested a review from havan September 18, 2024 13:33
proto/cmp/services/book/v2/mint.proto Outdated Show resolved Hide resolved
mo-c4t and others added 7 commits September 23, 2024 15:17
…reated files to make sure that the references to definitions in the same file are also updated correctly. Also added a space at the end of search/replace to not catch other definitions which start with the same prefix.
proto/cmp/services/book/v2/mint.proto Outdated Show resolved Hide resolved
proto/cmp/services/book/v2/mint.proto Outdated Show resolved Hide resolved
@mo-c4t mo-c4t requested a review from havan September 23, 2024 13:37
@havan havan changed the title mint v2 MintService v2 Sep 23, 2024
@havan havan merged commit c576cd0 into dev Sep 23, 2024
7 checks passed
@havan havan deleted the mint-v2 branch September 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants