Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diff script #35

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Adding diff script #35

merged 6 commits into from
Sep 19, 2024

Conversation

Noctunus
Copy link
Member

Added script to help with diffs against other branches with the version structure we've decided on

Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how the script will be used?

scripts/diff_against_dev.sh Outdated Show resolved Hide resolved
@Noctunus
Copy link
Member Author

Can you explain how the script will be used?

Execute the script in the base directory of a branch and it will do the diff against dev and show the difference of the added files to the existing files in dev with version-1.

This is described in the header of the script - or is that not clear by the comment?

@havan
Copy link
Member

havan commented Sep 19, 2024

This is described in the header of the script - or is that not clear by the comment?

I ran it and got no result but I then realized that it only checks added files.

Noctunus and others added 5 commits September 19, 2024 17:23
…etect local non-committed changes. Added check for modified files. Added TODO for script execution.
…et branch including an early exit with an error code for a workflow to react on that
@Noctunus Noctunus merged commit 1f2f4ef into dev Sep 19, 2024
10 checks passed
@Noctunus Noctunus deleted the diff-script-dev branch September 19, 2024 19:28
mo-c4t pushed a commit that referenced this pull request Sep 20, 2024
* Added script to help with diffs against other branches with the version structure we've decided on
* Added check for structural changes in existing files against the target branch 
* Added workflow job for the diff against script

---------

Co-authored-by: Noctunus <[email protected]>
Co-authored-by: Ekrem Seren <[email protected]>
mo-c4t pushed a commit that referenced this pull request Sep 20, 2024
* Added script to help with diffs against other branches with the version structure we've decided on
* Added check for structural changes in existing files against the target branch 
* Added workflow job for the diff against script

---------

Co-authored-by: Noctunus <[email protected]>
Co-authored-by: Ekrem Seren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants