Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate buf config to version 2 #37

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Migrate buf config to version 2 #37

merged 1 commit into from
Sep 20, 2024

Conversation

havan
Copy link
Member

@havan havan commented Sep 20, 2024

This migrates the buf's config version to v2.

Warning

You may need to update your buf cli tool to latest version

@mo-c4t
Copy link
Member

mo-c4t commented Sep 20, 2024

You moved buf.yaml to the root folder and you set the path to proto inside. I think there should be a change in ci.yaml workflow, to remove proto from the command: Example : buf format proto should be buf format

@havan
Copy link
Member Author

havan commented Sep 20, 2024

You moved buf.yaml to the root folder and you set the path to proto inside. I think there should be a change in ci.yaml workflow, to remove proto from the command: Example : buf format proto should be buf format

The config migrate script moved it. But we don't have any protobuf files other than the proto folder. So, I think it should stay, wdyt?

@havan havan merged commit 8912177 into dev Sep 20, 2024
5 checks passed
@havan havan deleted the buf-bump-version branch September 20, 2024 09:52
mo-c4t pushed a commit that referenced this pull request Sep 20, 2024
mo-c4t pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants