Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helix): allow to extend config from kurtosis config file #25

Merged
merged 4 commits into from
Nov 12, 2024
Merged

feat(helix): allow to extend config from kurtosis config file #25

merged 4 commits into from
Nov 12, 2024

Conversation

thedevbirb
Copy link

@thedevbirb thedevbirb commented Nov 11, 2024 •
edited
Loading

This PR allows using the kurtosis_config.yaml file as follows:

mev_params:
    # ...
    helix_relay_config_extension:
    	constraints_api_config:
      		check_constraints_signature: false
      		max_block_value_to_verify_wei: "0x00000000000000000000000000000000000000000000000000000000deadbeef"
     # ...

merklefruit
merklefruit approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

src/mev/mev_relay/helix_launcher.star
@@ -162,6 +163,8 @@ def launch_helix_relay(
),
)

plan.print(json.indent(json.encode(helix_config_template_data)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this useful?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it shows a nice print with the config which Helix is trying to run. Other services do that as well and I think it's useful.

src/mev/mev_relay/helix_launcher.star Show resolved Hide resolved
@thedevbirb thedevbirb merged commit 1a8ec7e into bolt Nov 12, 2024
4 of 12 checks passed
@thedevbirb thedevbirb deleted the lore/feat/helix-constraints-api-config branch November 12, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thedevbirb @merklefruit