Skip to content

fix(radio-group): hide indicator when the value is null #2335

fix(radio-group): hide indicator when the value is null

fix(radio-group): hide indicator when the value is null #2335

Triggered via pull request October 3, 2023 18:15
Status Success
Total duration 4m 3s
Artifacts

quality.yml

on: pull_request
Matrix: End-to-end Tests
Fit to window
Zoom out
Zoom in

Annotations

3 errors, 13 warnings, and 12 notices
dialog.e2e.ts:38:7 › dialog › should trap focus within dialog: e2e/dialog.e2e.ts#L44
1) dialog.e2e.ts:38:7 › dialog › should trap focus within dialog ───────────────────────────────── Error: Timed out 10000ms waiting for expect(received).toBeFocused() Call log: - expect.toBeFocused with timeout 10000ms - waiting for locator('[data-testid=close\\-1]') - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" 42 | await page.keyboard.press("Tab") 43 | await page.keyboard.press("Tab") > 44 | await expect(page.locator(dialog_1.close)).toBeFocused() | ^ 45 | }) 46 | 47 | test("should close modal on escape", async ({ page }) => { at /home/runner/work/zag/zag/e2e/dialog.e2e.ts:44:48
dialog.e2e.ts:38:7 › dialog › should trap focus within dialog: e2e/dialog.e2e.ts#L44
1) dialog.e2e.ts:38:7 › dialog › should trap focus within dialog ───────────────────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 10000ms waiting for expect(received).toBeFocused() Call log: - expect.toBeFocused with timeout 10000ms - waiting for locator('[data-testid=close\\-1]') 42 | await page.keyboard.press("Tab") 43 | await page.keyboard.press("Tab") > 44 | await expect(page.locator(dialog_1.close)).toBeFocused() | ^ 45 | }) 46 | 47 | test("should close modal on escape", async ({ page }) => { at /home/runner/work/zag/zag/e2e/dialog.e2e.ts:44:48
dialog.e2e.ts:67:7 › nested dialog › should trap focus: e2e/dialog.e2e.ts#L72
2) dialog.e2e.ts:67:7 › nested dialog › should trap focus ──────────────────────────────────────── Error: Timed out 10000ms waiting for expect(received).toBeFocused() Call log: - expect.toBeFocused with timeout 10000ms - waiting for locator('[data-testid=close\\-2]') - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" - locator resolved to <button type="button" data-scope="dialog" data-testid="c…>X</button> - unexpected value "not focused" 70 | await page.keyboard.press("Tab") 71 | await page.keyboard.press("Tab") > 72 | await expect(page.locator(dialog_2.close)).toBeFocused() | ^ 73 | }) 74 | 75 | test("should focus on nested buttton on escape", async ({ page }) => { at /home/runner/work/zag/zag/e2e/dialog.e2e.ts:72:48
Slow Test: numberinput.e2e.ts#L1
numberinput.e2e.ts took 18.6s
Slow Test: radio-group.e2e.ts#L1
radio-group.e2e.ts took 17.7s
Slow Test: popover.e2e.ts#L1
popover.e2e.ts took 17.2s
Slow Test: pin-input.e2e.ts#L1
pin-input.e2e.ts took 16.1s
Slow Test: accordion.e2e.ts#L1
accordion.e2e.ts took 16.5s
Slow Test: combobox.e2e.ts#L1
combobox.e2e.ts took 31.8s
Slow Test: nested-menu.e2e.ts#L1
nested-menu.e2e.ts took 25.7s
Slow Test: tags-input.e2e.ts#L1
tags-input.e2e.ts took 15.9s
Slow Test: hover-card.e2e.ts#L1
hover-card.e2e.ts took 23.8s
Slow Test: tooltip.e2e.ts#L1
tooltip.e2e.ts took 16.0s
Slow Test: dialog.e2e.ts#L1
dialog.e2e.ts took 56.9s
Slow Test: date-picker.e2e.ts#L1
date-picker.e2e.ts took 39.0s
Slow Test: select.e2e.ts#L1
select.e2e.ts took 1.3m
🎭 Playwright Run Summary
7 passed (25.7s)
🎭 Playwright Run Summary
2 skipped 17 passed (40.1s)
🎭 Playwright Run Summary
1 skipped 16 passed (37.4s)
🎭 Playwright Run Summary
20 passed (44.1s)
🎭 Playwright Run Summary
21 passed (47.4s)
🎭 Playwright Run Summary
18 passed (42.7s)
🎭 Playwright Run Summary
18 passed (47.6s)
🎭 Playwright Run Summary
22 passed (49.2s)
🎭 Playwright Run Summary
17 passed (49.4s)
🎭 Playwright Run Summary
11 passed (43.5s)
🎭 Playwright Run Summary
2 flaky dialog.e2e.ts:38:7 › dialog › should trap focus within dialog ────────────────────────────────── dialog.e2e.ts:67:7 › nested dialog › should trap focus ───────────────────────────────────────── 21 passed (1.9m)
🎭 Playwright Run Summary
28 passed (1.6m)