fix(dialog): remove hidden attr from positioner

chakra-ui · Nov 9, 2023 · 259f358 · 259f358 · vercel · Nov 9, 2023
1 parent 8fb5e73
commit 259f358
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/thirty-chairs-tickle.md b/.changeset/thirty-chairs-tickle.md
@@ -0,0 +1,8 @@
+---
+"@zag-js/dialog": patch
+---
+
+Fix issue where dialog positioner applied the `hidden` attribute when closed leading to pre-mature exit of css
+animations applied to the dialog content.
+
+> Only the backdrop and content should use the `hidden` attribute.
diff --git a/packages/machines/dialog/src/dialog.connect.ts b/packages/machines/dialog/src/dialog.connect.ts
@@ -42,9 +42,7 @@ export function connect<T extends PropTypes>(state: State, send: Send, normalize
     positionerProps: normalize.element({
       ...parts.positioner.attrs,
       dir: state.context.dir,
-      hidden: !isOpen,
       id: dom.getPositionerId(state.context),
-      "data-state": isOpen ? "open" : "closed",
       style: {
         pointerEvents: isOpen ? undefined : "none",
       },