Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: event handling in machines #789

Merged
merged 45 commits into from
Aug 16, 2023
Merged

refactor: event handling in machines #789

merged 45 commits into from
Aug 16, 2023

Conversation

segunadebayo
Copy link
Member

📝 Description

After using Zag.js in real-world projects, the "controlled" scenarios don't work well esp when using form libraries like react-hook-form.

This PR fixes the edge cases with invoke* functions

⛳️ Current behavior (updates)

Flaky controlled scenarios

🚀 New behavior

Works as expected

💣 Is this a breaking change (Yes/No):

Somewhat

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2023

🦋 Changeset detected

Latest commit: 23085e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 64 packages
Name Type
@zag-js/tags-input Minor
@zag-js/accordion Minor
@zag-js/color-picker Minor
@zag-js/number-input Minor
@zag-js/range-slider Minor
@zag-js/rating-group Minor
@zag-js/toggle-group Minor
@zag-js/date-picker Minor
@zag-js/file-upload Minor
@zag-js/radio-group Minor
@zag-js/hover-card Minor
@zag-js/pagination Minor
@zag-js/dom-query Minor
@zag-js/pin-input Minor
@zag-js/pressable Minor
@zag-js/carousel Minor
@zag-js/checkbox Minor
@zag-js/combobox Minor
@zag-js/editable Minor
@zag-js/presence Minor
@zag-js/splitter Minor
@zag-js/popover Minor
@zag-js/tooltip Minor
@zag-js/avatar Minor
@zag-js/dialog Minor
@zag-js/select Minor
@zag-js/slider Minor
@zag-js/switch Minor
@zag-js/toggle Minor
@zag-js/toast Minor
@zag-js/menu Minor
@zag-js/tabs Minor
@zag-js/aria-hidden Minor
@zag-js/auto-resize Minor
@zag-js/dismissable Minor
@zag-js/focus-scope Minor
@zag-js/focus-visible Minor
@zag-js/interact-outside Minor
@zag-js/popper Minor
@zag-js/remove-scroll Minor
@zag-js/tabbable Minor
@zag-js/text-selection Minor
@zag-js/dom-event Minor
@zag-js/anatomy-icons Minor
@zag-js/anatomy Minor
@zag-js/core Minor
@zag-js/docs Minor
@zag-js/react Minor
@zag-js/solid Minor
@zag-js/vue Minor
@zag-js/store Minor
@zag-js/types Minor
@zag-js/color-utils Minor
@zag-js/utils Minor
@zag-js/date-utils Minor
@zag-js/element-rect Minor
@zag-js/element-size Minor
@zag-js/form-utils Minor
@zag-js/live-region Minor
@zag-js/mutation-observer Minor
@zag-js/number-utils Minor
@zag-js/numeric-range Minor
@zag-js/rect-utils Minor
@zag-js/visually-hidden Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Aug 16, 2023 9:56am
zag-solid ✅ Ready (Inspect) Visit Preview Aug 16, 2023 9:56am
zag-vue ✅ Ready (Inspect) Visit Preview Aug 16, 2023 9:56am
zag-website ✅ Ready (Inspect) Visit Preview Aug 16, 2023 9:56am

@github-actions
Copy link
Contributor

Visualize the logic of the machines here 🎊

Copy link
Member Author

@segunadebayo segunadebayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Review: 👍🏽

@segunadebayo segunadebayo merged commit db81eaa into main Aug 16, 2023
16 checks passed
@segunadebayo segunadebayo deleted the refactor/machine branch August 16, 2023 10:04
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant