-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(file-upload): fix reopening the system file picker on browsers other than Chrome #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dropzone (not root) element
…n browsers other than Chrome
🦋 Changeset detectedLatest commit: 2748212 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
srflp
changed the title
fix(file-upload): fix opening system file picker multiple times on browsers other than Chrome
fix(file-upload): fix reopening the system file picker on browsers other than Chrome
Sep 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
According to Павлюткин Артём from Discord (https://discord.com/channels/964648323304808488/964648323304808496/1151315874020605972):
I also discovered that the problem also occurs on Firefox and Safari on macOS and I confirm that it occurs on Safari on iOS.
⛳️ Current behavior (updates)
🚀 New behavior
Instead of going into "open" state, existing idle/focused states are used.
OPEN and DROPZONE.CLICK transitions (in idle/focused state) are bound to an action that opens the system file picker.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information