Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): handle loop property correctly #950

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

srflp
Copy link
Contributor

@srflp srflp commented Oct 19, 2023

📝 Description

Sooo.. support for loop property in Combobox got deleted at some point. Combobox ignored the loop property and always looped. I reimplemented the loop property and added some tests which test the Combobox with loop property equal to false.

⛳️ Current behavior (updates)

Combobox is looping even when loop=false.

🚀 New behavior

Combobox is looping only when loop=true.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Additionally I remove a duplicated item from a combobox list example and fix some typos.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 7c800ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 64 packages
Name Type
@zag-js/combobox Patch
@zag-js/anatomy-icons Patch
@zag-js/anatomy Patch
@zag-js/core Patch
@zag-js/docs Patch
@zag-js/react Patch
@zag-js/solid Patch
@zag-js/vue Patch
@zag-js/accordion Patch
@zag-js/avatar Patch
@zag-js/carousel Patch
@zag-js/checkbox Patch
@zag-js/color-picker Patch
@zag-js/date-picker Patch
@zag-js/dialog Patch
@zag-js/editable Patch
@zag-js/file-upload Patch
@zag-js/hover-card Patch
@zag-js/menu Patch
@zag-js/number-input Patch
@zag-js/pagination Patch
@zag-js/pin-input Patch
@zag-js/popover Patch
@zag-js/presence Patch
@zag-js/radio-group Patch
@zag-js/rating-group Patch
@zag-js/select Patch
@zag-js/slider Patch
@zag-js/splitter Patch
@zag-js/switch Patch
@zag-js/tabs Patch
@zag-js/tags-input Patch
@zag-js/toast Patch
@zag-js/toggle-group Patch
@zag-js/tooltip Patch
@zag-js/store Patch
@zag-js/types Patch
@zag-js/aria-hidden Patch
@zag-js/auto-resize Patch
@zag-js/collection Patch
@zag-js/color-utils Patch
@zag-js/utils Patch
@zag-js/date-utils Patch
@zag-js/dismissable Patch
@zag-js/dom-event Patch
@zag-js/dom-query Patch
@zag-js/element-rect Patch
@zag-js/element-size Patch
@zag-js/file-utils Patch
@zag-js/focus-scope Patch
@zag-js/focus-visible Patch
@zag-js/form-utils Patch
@zag-js/i18n-utils Patch
@zag-js/interact-outside Patch
@zag-js/live-region Patch
@zag-js/mutation-observer Patch
@zag-js/number-utils Patch
@zag-js/numeric-range Patch
@zag-js/popper Patch
@zag-js/rect-utils Patch
@zag-js/remove-scroll Patch
@zag-js/tabbable Patch
@zag-js/text-selection Patch
@zag-js/visually-hidden Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Oct 19, 2023 10:48pm
zag-solid ✅ Ready (Inspect) Visit Preview Oct 19, 2023 10:48pm
zag-vue ✅ Ready (Inspect) Visit Preview Oct 19, 2023 10:48pm
zag-website ✅ Ready (Inspect) Visit Preview Oct 19, 2023 10:48pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants