fix(combobox): handle loop property correctly #950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Sooo.. support for loop property in Combobox got deleted at some point. Combobox ignored the loop property and always looped. I reimplemented the loop property and added some tests which test the Combobox with loop property equal to false.
⛳️ Current behavior (updates)
Combobox is looping even when loop=false.
🚀 New behavior
Combobox is looping only when loop=true.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Additionally I remove a duplicated item from a combobox list example and fix some typos.